fix(opencode): use toLowerCase for Devstral model detection#33109
Merged
Conversation
toLocaleLowerCase is locale-sensitive and can break model-id matching in Turkish locale (I -> ı). Every other model-id check in this file already uses toLowerCase. Closes anomalyco#33108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33108
Type of change
What does this PR do?
Changes
toLocaleLowerCase()totoLowerCase()in the Devstral model detection check (packages/opencode/src/provider/transform.ts:221). The adjacent Mistral check on line 220 already usestoLowerCase(), and every other model-id check in this file does too.toLocaleLowerCase()is locale-sensitive — in Turkish locale it convertsItoı(dotless i), which would causeincludes("devstral")to fail.How did you verify your code works?
bun turbo typecheck: all 29 packages passChecklist